Add per-file diff details to the github comments.

fablab-bergamo · Apr 28, 2024 · f52b5f5 · f52b5f5
1 parent 49b6196
commit f52b5f5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/sizes.yml b/.github/workflows/sizes.yml
@@ -58,7 +58,7 @@ jobs:
         run: cp .pio/build/${{ matrix.variant }}/firmware.map ../firmware.map.previous
       # Now compares both MAP files with esp_idf_size
       - name: Compare MAP files
-        run: python -m esp_idf_size --format=text --diff=../firmware.map.previous ../firmware.map.latest -o size_report.txt
+        run: python -m esp_idf_size --format=text --files --diff=../firmware.map.previous ../firmware.map.latest -o size_report.txt
       # Upload the size report as an artifact
       - name: Upload size report
         uses: actions/upload-artifact@v4

diff --git a/src/SavedConfig.cpp b/src/SavedConfig.cpp
@@ -12,7 +12,7 @@
 
 namespace fablabbg
 {
-  // Define the static variable
+  // Define the static variables
   std::string SavedConfig::json_buffer;
   std::mutex SavedConfig::buffer_mutex;
 

diff --git a/tools/metrics_firmware.py b/tools/metrics_firmware.py
@@ -25,7 +25,9 @@ def firm_metrics(source, target, env):
             + '"'
         )
         env.Execute(
-            '$PYTHONEXE -m esp_idf_size --format=text "' + str(firmware_file) + '"'
+            '$PYTHONEXE -m esp_idf_size --files --format=text "'
+            + str(firmware_file)
+            + '"'
         )