Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposure is not a database column #282

Open
oscgonfer opened this issue Nov 9, 2023 · 2 comments
Open

Exposure is not a database column #282

oscgonfer opened this issue Nov 9, 2023 · 2 comments
Assignees
@timcowlishaw @pral2a @oscgonfer
Labels
enhancement help wanted
Milestone
Forwarding and st...

Comments

@oscgonfer
Copy link
Contributor

oscgonfer commented Nov 9, 2023 •
edited
Loading

  1. Devices can't be searched by 'exposure', which mystified me until i realised that 'exposure' isn't actually a database column, it's a field in a json metadata blob, which ransack can't search. We could move this out to its own column to make it searchable, but i think, again, it'd be worth doing that after the refactor!

Originally posted by @timcowlishaw in #257 (comment)
@oscgonfer oscgonfer added this to the Post-refactor milestone Nov 9, 2023
@oscgonfer oscgonfer mentioned this issue Dec 22, 2023
Open
@oscgonfer
Copy link
Contributor Author

Conflicting: #12

@oscgonfer oscgonfer self-assigned this Apr 12, 2024
@oscgonfer
Copy link
Contributor Author

Action (TBC by @pral2a because we don't understand why it's in system_tags):

  • make it searchable by making it a database column
  • remove from system_tags
  • remove from location
  • add to object itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timcowlishaw timcowlishaw

@pral2a pral2a

@oscgonfer oscgonfer

Labels
enhancement help wanted
Projects
None yet
Milestone
Forwarding and standarisation
Development

No branches or pull requests
3 participants
@timcowlishaw @pral2a @oscgonfer