Move all avatars to profile_picture and ensure that profile_picture is included in responses #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcowlishaw
force-pushed
the
bugfix/always-send-profile-picture-with-user
branch
from
cacd017 to
0e5c3d8
Compare
|
@oscgonfer it'd be good to get this one into production soonish too if possible as it's kinda necessary for the profile-pictures work i need to do on smartcitizen-web! |
timcowlishaw
added a commit
to fablabbcn/smartcitizen-web
that referenced
this pull request
Oct 26, 2023
the User#avatar property is both deprecated and broken - this removs all reference to it from this application, using the new profile_picture field instead. Depends on fablabbcn/smartcitizen-api#271 and will need some testing once that is deployed.
timcowlishaw
changed the title
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
timcowlishaw
added a commit
to fablabbcn/smartcitizen-web
that referenced
this pull request
Nov 20, 2023
the User#avatar property is both deprecated and broken - this removs all reference to it from this application, using the new profile_picture field instead. Depends on fablabbcn/smartcitizen-api#271 and will need some testing once that is deployed.
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-web
that referenced
this pull request
Nov 23, 2023
the User#avatar property is both deprecated and broken - this removs all reference to it from this application, using the new profile_picture field instead. Depends on fablabbcn/smartcitizen-api#271 and will need some testing once that is deployed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #166 - Currently, in various places where fablabbcn/smartcitizen-web renders a user, no profile picture is provided, leaving the default avatar showing.
I've also added a task
rake import:old_avatar_imageswhich will copy the old avatar across to the profile_picture for all users with an avatar who don't yet have a profile_picture. This will probably not do much in staging as it uses a different s3 bucket, but works well locally setting the credentials manually. When we run in production we should keep an eye on sidekiq to make sure the ActiveStorage AnalysisJobs complete successfully.