Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monolith Part 1: Incorporate id.sc functionality into the app and decommision. #371

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

timcowlishaw
Copy link
Contributor

@timcowlishaw timcowlishaw commented Oct 20, 2024

This also has the nice side effect of sorting out the need for persistent sessions, and all the rails HTML/CSS/JS infrastructure for us for future monolith work.

In the process I am removing the old id.smartcitizen.me Oauth app management interface, as discussed. Session management and the discord callback have been brought into the "monolith", and redirects set up on the id.smartcitizen host.

I've also added tests for the auth functionality.

Merged to staging on 20/10/2024 on the branch staging-2024-10-10.

On deploying, we should clean up oauth apps in the database too, and remember to precompile assets

@timcowlishaw timcowlishaw force-pushed the monolith branch 2 times, most recently from 752da98 to c02e6da Compare October 20, 2024 15:06
@timcowlishaw timcowlishaw marked this pull request as ready for review October 20, 2024 15:18
@timcowlishaw timcowlishaw merged commit 582db3d into master Oct 23, 2024
2 checks passed
@timcowlishaw timcowlishaw deleted the monolith branch October 23, 2024 15:02
Copy link

sentry-io bot commented Oct 31, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ActionView::Template::Error: The asset "smartcitizen_logo.svg" is not present in the asset pipeline. Ui::SessionsController#new View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants