Skip to content

Commit

Permalink
Redirect plugin build stdout and pass to logger. (#3763)
Browse files Browse the repository at this point in the history
* Redirect plugin build stdout and pass to logger.

* Add changelog entry.
  • Loading branch information
nojaf authored Feb 20, 2024
1 parent 22bf471 commit d37c262
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
4 changes: 4 additions & 0 deletions src/Fable.Compiler/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* [GH-3758](https://github.com/fable-compiler/Fable/pull/3758) Endpoint to get Fable.AST for a file. (by @nojaf)

### Fixed

* [GH-3763](https://github.com/fable-compiler/Fable/pull/3763) Redirect plugin build stdout and pass to logger. (by @nojaf)

## 4.0.0-alpha-006 - 2024-02-12

### Changed
Expand Down
6 changes: 4 additions & 2 deletions src/Fable.Compiler/ProjectCracker.fs
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,10 @@ type CrackerOptions(cliArgs: CliArgs, evaluateOnly: bool) =
|> Array.rev
|> String.concat "/"

Process.runSync projDir "dotnet" [ "build"; "-c"; cliArgs.Configuration ]
|> ignore
let stdout =
Process.runSyncWithOutput projDir "dotnet" [ "build"; "-c"; cliArgs.Configuration ]

Log.always stdout

builtDlls.Add(normalizedDllPath) |> ignore

Expand Down
2 changes: 2 additions & 0 deletions src/Fable.Compiler/Util.fsi
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ module Process =

val runSync: workingDir: string -> exePath: string -> args: string list -> int

val runSyncWithOutput: string -> string -> string list -> string

type PathResolver =
abstract TryPrecompiledOutPath: sourceDir: string * relativePath: string -> string option

Expand Down

0 comments on commit d37c262

Please sign in to comment.