feat: fix fable-compiler-js when run from NPM (#3795)

* `--version` is working but can't compile yet * feat: return the current directory inode insead of an empty string if the provided path is just a filename * chore: update changelog
fable-compiler · May 23, 2024 · fade279 · fade279
1 parent 6a8f4e4
commit fade279
Show file tree

Hide file tree

Showing 9 changed files with 61 additions and 37 deletions.
diff --git a/src/fable-compiler-js/CHANGELOG.md b/src/fable-compiler-js/CHANGELOG.md
@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Changed
+
+* Use `@fable-org/fable-metadata` package instead of `fable-metadata` (by @MangelMaxime)
+* Use `@fable-org/fable-standalone` package instead of `fable-standalone` (by @MangelMaxime)
+* Make `GetDirectoryName` return `"."` instead of `""` if the path doesn't contain any directory (by @MangelMaxime)
+
+### Fixed
+
+* Fix initialization of `fable-standalone` with the new package format (by @MangelMaxime)
+
 ## 1.1.0 - 2024-02-20
 
 * Add `NPM_PACKAGE_FABLE_COMPILER_JAVASCRIPT` compiler directive (by @MangelMaxime)

diff --git a/src/fable-compiler-js/package-lock.json b/src/fable-compiler-js/package-lock.json
diff --git a/src/fable-compiler-js/package.json b/src/fable-compiler-js/package.json
@@ -24,8 +24,8 @@
   },
   "homepage": "https://github.com/fable-compiler/Fable#readme",
   "dependencies": {
-    "fable-metadata": "^2.0.0",
-    "fable-standalone": "^3.0.0"
+    "@fable-org/fable-metadata": "^1.0.0",
+    "@fable-org/fable-standalone": "^1.4.0"
   },
   "devDependencies": {
     "esbuild": "^0.19.5",

diff --git a/src/fable-compiler-js/src/Platform.fs b/src/fable-compiler-js/src/Platform.fs
@@ -143,6 +143,6 @@ module Path =
         let i = normPath.LastIndexOf('/')
 
         if i < 0 then
-            ""
+            "."
         else
             normPath.Substring(0, i)
diff --git a/src/fable-compiler-js/src/app.fs b/src/fable-compiler-js/src/app.fs
@@ -33,8 +33,16 @@ let getMetadataDir () : string =
 let getFableLibDir () : string = importMember "./util.js"
 let getVersion () : string = importMember "./util.js"
 
-let initFable () : Fable.Standalone.IFableManager =
-    import "init" "@fable-org/fable-standalone"
+type IFableInit =
+    abstract member init: unit -> Fable.Standalone.IFableManager
+
+// Make __FABLE_STANDALONE__ available in the global scope
+importSideEffects "@fable-org/fable-standalone"
+
+[<Global("__FABLE_STANDALONE__")>]
+let FableInit: IFableInit = jsNative
+
+let initFable () : Fable.Standalone.IFableManager = FableInit.init ()
 #endif
 
 let references = Fable.Metadata.coreAssemblies

diff --git a/src/fable-metadata/CHANGELOG.md b/src/fable-metadata/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Fixed
+
+* Make `dirname-filename-esm` a `dependency` instead of a `devDependency`
+
 ## 1.0.0 - 2024-02-12
 
 * Release stable version

diff --git a/src/fable-metadata/package-lock.json b/src/fable-metadata/package-lock.json
diff --git a/src/fable-metadata/package.json b/src/fable-metadata/package.json
@@ -18,7 +18,7 @@
   ],
   "author": ".NET Foundation and Contributors",
   "license": "MIT",
-  "devDependencies": {
+  "dependencies": {
     "dirname-filename-esm": "^1.1.1"
   }
 }
diff --git a/src/fable-standalone/CHANGELOG.md b/src/fable-standalone/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Fixed
+
+* Make `dirname-filename-esm` a `dependency` instead of a `devDependency`
+
 ## 1.5.0 - 2024-03-20
 
 ### Changed