Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default value for Fantomas fsharp_array_or_list_multiline_formatter #3751

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

ncave
Copy link
Collaborator

@ncave ncave commented Feb 10, 2024

  • Use default value for Fantomas fsharp_array_or_list_multiline_formatter.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ionide.Analyzers.Cli found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@ncave ncave changed the title Set Fantomas fsharp_max_array_or_list_number_of_items to 3 Use default value for Fantomas fsharp_record_multiline_formatter Feb 10, 2024
@ncave ncave changed the title Use default value for Fantomas fsharp_record_multiline_formatter Use default value for Fantomas fsharp_array_or_list_multiline_formatter Feb 10, 2024
@ncave
Copy link
Collaborator Author

ncave commented Feb 10, 2024

@MangelMaxime It's ready for review now.

format.Type
thisArg.Value.Type
],
[ format; thisArg.Value ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
thisArg.Value.Type
],
[ format; thisArg.Value ],
[ format.Type; thisArg.Value.Type ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
format.Type
thisArg.Value.Type
],
[ format; thisArg.Value ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
thisArg.Value.Type
],
[ format; thisArg.Value ],
[ format.Type; thisArg.Value.Type ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
thisArg.Value.Type
kind.Type
],
[ thisArg.Value; kind ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
thisArg.Value.Type
],
[ format; thisArg.Value ],
[ format.Type; thisArg.Value.Type ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
format.Type
thisArg.Value.Type
],
[ format; thisArg.Value ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
thisArg.Value.Type
],
[ format; thisArg.Value ],
[ format.Type; thisArg.Value.Type ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
thisArg.Value.Type
kind.Type
],
[ thisArg.Value; kind ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
kind.Type
],
[ thisArg.Value; kind ],
[ thisArg.Value.Type; kind.Type ],

Check warning

Code scanning / Ionide.Analyzers.Cli

Replace unsafe option unwrapping with graceful handling of each case. Warning

Replace unsafe option unwrapping with graceful handling of each case.
@MangelMaxime MangelMaxime merged commit df40a18 into fable-compiler:main Feb 11, 2024
19 checks passed
@MangelMaxime
Copy link
Member

Thank you @ncave.

It looks like it improves code readability in most cases, especially in Fable internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants