-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default value for Fantomas fsharp_array_or_list_multiline_formatter #3751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ionide.Analyzers.Cli found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
@MangelMaxime It's ready for review now. |
format.Type | ||
thisArg.Value.Type | ||
], | ||
[ format; thisArg.Value ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
thisArg.Value.Type | ||
], | ||
[ format; thisArg.Value ], | ||
[ format.Type; thisArg.Value.Type ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
format.Type | ||
thisArg.Value.Type | ||
], | ||
[ format; thisArg.Value ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
thisArg.Value.Type | ||
], | ||
[ format; thisArg.Value ], | ||
[ format.Type; thisArg.Value.Type ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
thisArg.Value.Type | ||
kind.Type | ||
], | ||
[ thisArg.Value; kind ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
thisArg.Value.Type | ||
], | ||
[ format; thisArg.Value ], | ||
[ format.Type; thisArg.Value.Type ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
format.Type | ||
thisArg.Value.Type | ||
], | ||
[ format; thisArg.Value ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
thisArg.Value.Type | ||
], | ||
[ format; thisArg.Value ], | ||
[ format.Type; thisArg.Value.Type ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
thisArg.Value.Type | ||
kind.Type | ||
], | ||
[ thisArg.Value; kind ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
kind.Type | ||
], | ||
[ thisArg.Value; kind ], | ||
[ thisArg.Value.Type; kind.Type ], |
Check warning
Code scanning / Ionide.Analyzers.Cli
Replace unsafe option unwrapping with graceful handling of each case. Warning
Thank you @ncave. It looks like it improves code readability in most cases, especially in Fable internals. |
fsharp_array_or_list_multiline_formatter
.