Fixes #3837

[ncave]

• [JS/TS] Fixed missing field using TypeScriptTaggedUnion (Missing discriminator field when using TypeScriptTaggedUnion #3837)

[ncave]

@MangelMaxime For some reason that I don't quite understand, there seems to be a special case for single unnamed union case fields (when used with TypeScriptTaggedUnion).

Disabling it fixes the linked issue, tests are still passing, but please chime in if you know more about it.

[MangelMaxime]

I don't know much about TypeScriptTaggedUnion.

I never really used the TypeScript target unless for writing the documentation about it. Which is kind of ironic 🤣

I suppose you left the previous code commented on purpose?

[ncave]

@MangelMaxime

I suppose you left the previous code commented on purpose?

Yes, as I don't understand what was it supposed to do (some sort of optimization perhaps for certain cases of unions with only one unnamed field?).
And it's not just for TypeScript. Using TypeScriptTaggedUnion attribute will add a tag property for JS too.

[MangelMaxime]

Perhaps, it was trying to do something similar to StringEnum which allows to map DUs case to a string.

But if someone, wants to do that they can use StringEnum and now TypeScriptTaggedUnion is consistent for all type of cases. We will see, if someone report a problem with it that we are not aware of.