Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light theme #71

Open
alfonsogarciacaro opened this issue Nov 7, 2018 · 0 comments
Open

Add light theme #71

alfonsogarciacaro opened this issue Nov 7, 2018 · 0 comments

Comments

@alfonsogarciacaro
Copy link
Member

@vasily-kirichenko has requested a light theme for the editor. Given that we already offer options like setting the font, it can be a nice addition to be able to set the theme and hopefully it's not too difficult.

There are several guides to do theming with SASS, this one proposes to use a value dictionary and then a theming mixing to generate multiple rules prefixed with the theme name like:

$themes: (
  light: (
    backgroundColor: #fff,
    textColor: #408bbd,
  ),
  dark: (
    backgroundColor: #222,
    textColor: #ddd,
  ),
);

// Usage

.app-container {
  @include themify($themes) {
    color: themed('textColor');  
    background-color: themed('backgroundColor');  
  }
}

What do you think @MangelMaxime? Should we apply this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant