Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for debug mode #86

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Dec 11, 2017

No description provided.

// GetDebugMode returns if debug mode should be enabled as set via default, config file, or environment variable
func (c *Data) GetDebugMode() bool {
return c.v.GetBool(varDebugMode)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep GitHub happy one would need a newline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@@ -89,6 +89,8 @@ objects:
secretKeyRef:
name: jenkins-proxy
key: postgres.password
- name: JC_DEBUG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does JC stand for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I started to write idler I called it Jenkins Controller, so I used prefix JC...would be probably a good thing to refactor in the future so that it makes more sense..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created issue #87

@vpavlin vpavlin force-pushed the feature/add-flow-images branch from 999e8c8 to 5f8cdd7 Compare December 11, 2017 14:17
@@ -471,7 +471,7 @@ func (p *Proxy) RecordStatistics(ns string, la int64, lbf int64) (err error) {
}
}
if notFound {
log.Info("New user %s", ns)
log.Infof("New user %s", ns)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@hferentschik hferentschik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vpavlin vpavlin merged commit 0863ba0 into fabric8-services:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants