-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option for debug mode #86
Add configuration option for debug mode #86
Conversation
// GetDebugMode returns if debug mode should be enabled as set via default, config file, or environment variable | ||
func (c *Data) GetDebugMode() bool { | ||
return c.v.GetBool(varDebugMode) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep GitHub happy one would need a newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
@@ -89,6 +89,8 @@ objects: | |||
secretKeyRef: | |||
name: jenkins-proxy | |||
key: postgres.password | |||
- name: JC_DEBUG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does JC stand for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I started to write idler I called it Jenkins Controller, so I used prefix JC
...would be probably a good thing to refactor in the future so that it makes more sense..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created issue #87
999e8c8
to
5f8cdd7
Compare
@@ -471,7 +471,7 @@ func (p *Proxy) RecordStatistics(ns string, la int64, lbf int64) (err error) { | |||
} | |||
} | |||
if notFound { | |||
log.Info("New user %s", ns) | |||
log.Infof("New user %s", ns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.