Skip to content

Commit

Permalink
Fixup for linkage on doctests
Browse files Browse the repository at this point in the history
Summary:
We need to pass deps as immediate dependencies alongside the rlib when constructing linker args, so that we actually get the required `-lfoo` etc args on the link line.

Without this, we get undefined symbols when building doctests with `advanced_unstable_linking`.

Reviewed By: JakobDegen

Differential Revision: D61298029

fbshipit-source-id: 65594651e3f4716771b3e8d91bfd482fbd430222
  • Loading branch information
capickett authored and facebook-github-bot committed Aug 14, 2024
1 parent e0a7844 commit cad2f05
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion prelude/rust/build.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ def generate_rustdoc_test(
link_infos,
deps = inherited_merged_link_infos(ctx, doc_dep_ctx),
preferred_linkage = Linkage("static"),
)],
)] + inherited_merged_link_infos(ctx, doc_dep_ctx),
params.dep_link_strategy,
),
],
Expand Down

0 comments on commit cad2f05

Please sign in to comment.