Skip to content

Commit

Permalink
Fix Pascal Name Parsing Issue with Numbers
Browse files Browse the repository at this point in the history 
Summary: In Graph API v20, two words are introduced P2MInvoicePayments and WithAsset3D - causing the logic of parsing pascal name to fail and generate 'M' and 'D' as individual words. This caused the endpoint name parsing fail at last.

Reviewed By: yoongyj, liliarizona

Differential Revision: D61582281

fbshipit-source-id: 4b1cf3f966f433cf1c2a7fa4641ca8048857a0f5
  • Loading branch information
@stcheng @facebook-github-bot
stcheng authored and facebook-github-bot committed Aug 21, 2024
1 parent ba5771d commit 83e38d3
Show file tree
Hide file tree
Showing 14 changed files with 32 additions and 32 deletions.
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/AdAccount.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2421,7 +2421,7 @@ public function getIosFourteenCampaignLimits(array $fields = array(), array $par
return $pending ? $request : $request->execute();
}

public function createMAnAgeDPartnerAd(array $fields = array(), array $params = array(), $pending = false) {
public function createManagedPartnerAd(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/AdVideo.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public function createComment(array $fields = array(), array $params = array(),
return $pending ? $request : $request->execute();
}

public function getCrosspostShareDPages(array $fields = array(), array $params = array(), $pending = false) {
public function getCrosspostSharedPages(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
8 changes: 4 additions & 4 deletions src/FacebookAds/Object/AdsPixel.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ public function createShadowTrafficHelper(array $fields = array(), array $params
return $pending ? $request : $request->execute();
}

public function deleteShareDAccounts(array $fields = array(), array $params = array(), $pending = false) {
public function deleteSharedAccounts(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -393,7 +393,7 @@ public function deleteShareDAccounts(array $fields = array(), array $params = ar
return $pending ? $request : $request->execute();
}

public function getShareDAccounts(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedAccounts(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -417,7 +417,7 @@ public function getShareDAccounts(array $fields = array(), array $params = array
return $pending ? $request : $request->execute();
}

public function createShareDAccount(array $fields = array(), array $params = array(), $pending = false) {
public function createSharedAccount(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -442,7 +442,7 @@ public function createShareDAccount(array $fields = array(), array $params = arr
return $pending ? $request : $request->execute();
}

public function getShareDAgencies(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedAgencies(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
14 changes: 7 additions & 7 deletions src/FacebookAds/Object/Business.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,7 @@ public function getInstagramBusinessAccounts(array $fields = array(), array $par
return $pending ? $request : $request->execute();
}

public function deleteMAnAgeDBusinesses(array $fields = array(), array $params = array(), $pending = false) {
public function deleteManagedBusinesses(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -1504,7 +1504,7 @@ public function deleteMAnAgeDBusinesses(array $fields = array(), array $params =
return $pending ? $request : $request->execute();
}

public function createMAnAgeDBusiness(array $fields = array(), array $params = array(), $pending = false) {
public function createManagedBusiness(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -1539,7 +1539,7 @@ public function createMAnAgeDBusiness(array $fields = array(), array $params = a
return $pending ? $request : $request->execute();
}

public function createMAnAgeDPartnerBusinessSetup(array $fields = array(), array $params = array(), $pending = false) {
public function createManagedPartnerBusinessSetup(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -1569,7 +1569,7 @@ public function createMAnAgeDPartnerBusinessSetup(array $fields = array(), array
return $pending ? $request : $request->execute();
}

public function deleteMAnAgeDPartnerBusinesses(array $fields = array(), array $params = array(), $pending = false) {
public function deleteManagedPartnerBusinesses(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -1594,7 +1594,7 @@ public function deleteMAnAgeDPartnerBusinesses(array $fields = array(), array $p
return $pending ? $request : $request->execute();
}

public function createMAnAgeDPartnerBusiness(array $fields = array(), array $params = array(), $pending = false) {
public function createManagedPartnerBusiness(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -2807,7 +2807,7 @@ public function getPendingOwnedPages(array $fields = array(), array $params = ar
return $pending ? $request : $request->execute();
}

public function getPendingShareDOffsiteSignalContainerBusinessObjects(array $fields = array(), array $params = array(), $pending = false) {
public function getPendingSharedOffsiteSignalContainerBusinessObjects(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -3004,7 +3004,7 @@ public function getSelfCertifiedWhatsappBusinessSubmissions(array $fields = arra
return $pending ? $request : $request->execute();
}

public function createSetupMAnAgeDPartnerAdAccount(array $fields = array(), array $params = array(), $pending = false) {
public function createSetupManagedPartnerAdAccount(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/CommerceMerchantSettings.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public function getCommerceTransactions(array $fields = array(), array $params =
return $pending ? $request : $request->execute();
}

public function getOrderMAnAgeMEntApps(array $fields = array(), array $params = array(), $pending = false) {
public function getOrderManagementApps(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -169,7 +169,7 @@ public function getOrderMAnAgeMEntApps(array $fields = array(), array $params =
return $pending ? $request : $request->execute();
}

public function createOrderMAnAgeMEntApp(array $fields = array(), array $params = array(), $pending = false) {
public function createOrderManagementApp(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/CustomAudience.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ public function getSessions(array $fields = array(), array $params = array(), $p
return $pending ? $request : $request->execute();
}

public function getShareDAccountInfo(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedAccountInfo(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/EventSourceGroup.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ protected static function getReferencedEnums() {
}


public function getShareDAccounts(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedAccounts(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -69,7 +69,7 @@ public function getShareDAccounts(array $fields = array(), array $params = array
return $pending ? $request : $request->execute();
}

public function createShareDAccount(array $fields = array(), array $params = array(), $pending = false) {
public function createSharedAccount(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/ExtendedCredit.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public function createOwningCreditAllocationConfig(array $fields = array(), arra
return $pending ? $request : $request->execute();
}

public function createWhatsAppCreditSharingAnDAttach(array $fields = array(), array $params = array(), $pending = false) {
public function createWhatsAppCreditSharingAndAttach(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/Group.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ protected static function getReferencedEnums() {
}


public function deleteAdMIns(array $fields = array(), array $params = array(), $pending = false) {
public function deleteAdmins(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -96,7 +96,7 @@ public function deleteAdMIns(array $fields = array(), array $params = array(), $
return $pending ? $request : $request->execute();
}

public function createAdMIn(array $fields = array(), array $params = array(), $pending = false) {
public function createAdmin(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/LiveVideo.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public function getComments(array $fields = array(), array $params = array(), $p
return $pending ? $request : $request->execute();
}

public function getCrosspostShareDPages(array $fields = array(), array $params = array(), $pending = false) {
public function getCrosspostSharedPages(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/OfflineConversionDataSet.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public function getServerEventsPermittedBusiness(array $fields = array(), array
return $pending ? $request : $request->execute();
}

public function getShareDAccounts(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedAccounts(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -190,7 +190,7 @@ public function getShareDAccounts(array $fields = array(), array $params = array
return $pending ? $request : $request->execute();
}

public function getShareDAgencies(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedAgencies(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
8 changes: 4 additions & 4 deletions src/FacebookAds/Object/Page.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,7 @@ public function createMediaFingerprint(array $fields = array(), array $params =
return $pending ? $request : $request->execute();
}

public function createMessageAttachMEnt(array $fields = array(), array $params = array(), $pending = false) {
public function createMessageAttachment(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -2044,7 +2044,7 @@ public function createMessengerCallSetting(array $fields = array(), array $param
return $pending ? $request : $request->execute();
}

public function getMessengerLeadForMs(array $fields = array(), array $params = array(), $pending = false) {
public function getMessengerLeadForms(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand All @@ -2067,7 +2067,7 @@ public function getMessengerLeadForMs(array $fields = array(), array $params = a
return $pending ? $request : $request->execute();
}

public function createMessengerLeadForM(array $fields = array(), array $params = array(), $pending = false) {
public function createMessengerLeadForm(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -2863,7 +2863,7 @@ public function getRtbDynamicPosts(array $fields = array(), array $params = arra
return $pending ? $request : $request->execute();
}

public function getScheduleDPosts(array $fields = array(), array $params = array(), $pending = false) {
public function getScheduledPosts(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/PagePost.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ protected static function getReferencedEnums() {
}


public function getAttachMEnts(array $fields = array(), array $params = array(), $pending = false) {
public function getAttachments(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -294,7 +294,7 @@ public function getReactions(array $fields = array(), array $params = array(), $
return $pending ? $request : $request->execute();
}

public function getShareDPosts(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedPosts(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/Post.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ protected static function getReferencedEnums() {
}


public function getAttachMEnts(array $fields = array(), array $params = array(), $pending = false) {
public function getAttachments(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down Expand Up @@ -281,7 +281,7 @@ public function getReactions(array $fields = array(), array $params = array(), $
return $pending ? $request : $request->execute();
}

public function getShareDPosts(array $fields = array(), array $params = array(), $pending = false) {
public function getSharedPosts(array $fields = array(), array $params = array(), $pending = false) {
$this->assureId();

$param_types = array(
Expand Down

0 comments on commit 83e38d3

Please sign in to comment.