Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in readme and changelog #611

Closed
wants to merge 1 commit into from

Conversation

truongd3
Copy link

Issue #610

Fix typo errors in README.md and CHANGELOG.md

Description

README.md

  1. Missing Dollar Sign for Variable
    In the Create Objects section, the AdSetFields::CAMPAIGN_ID is missing a $ before campaign_id

  2. Code Block Syntax Highlighting
    Add shell tag for second code block line 335

CHANGELOG.md

  1. Missing Parenthesis for Link Attachment
    In the Unreleased v11.0.0, the link attached is missing a pair of parenthesis

@facebook-github-bot
Copy link

Hi @truongd3!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@truongd3 truongd3 changed the title fix typo in readme and changelog Fix typo in readme and changelog Aug 22, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@stcheng merged this pull request in 1fbdf60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants