Skip to content

Commit

Permalink
Network errors show up as errors
Browse files Browse the repository at this point in the history
Summary: We were only showing http errors as errors but if there was some kind of networking error this should be shown as an error also

Reviewed By: antonk52

Differential Revision: D57865639

fbshipit-source-id: 72487338bfe43d7ebe35685151c48af9deca6935
  • Loading branch information
Luke De Feo authored and facebook-github-bot committed Jun 3, 2024
1 parent b93fbbd commit a25e14b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions desktop/plugins/public/network/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -790,8 +790,8 @@ function getRowStyle(row: Request) {
? mockingStyle
: row.status &&
row.status !== '...' &&
parseInt(row.status, 10) >= 400 &&
parseInt(row.status, 10) < 600
((parseInt(row.status, 10) >= 400 && parseInt(row.status, 10) < 600) ||
parseInt(row.status, 10) === -1)
? errorStyle
: undefined;
}

0 comments on commit a25e14b

Please sign in to comment.