Clients to avoid sending payloads larger than the maximum allowed size

Summary: ^ Reviewed By: passy Differential Revision: D48645400 fbshipit-source-id: ac262296f113298812803c12eccf5a37da1da2b7
facebook · Aug 24, 2023 · ecc50f4 · ecc50f4
1 parent 865d551
commit ecc50f4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/android/src/main/cpp/sonar.cpp b/android/src/main/cpp/sonar.cpp
@@ -343,6 +343,13 @@ class JFlipperWebSocket : public facebook::flipper::FlipperSocket {
     if (socket_ == nullptr) {
       return;
     }
+    // Ensure the payload size is valid before sending.
+    // The maximum allowed size for a message payload is 2^53 - 1. But that is
+    // for the entire message, including any additional metadata.
+    if (message.length() > pow(2, 53) - 1) {
+      throw std::length_error("Payload is too big to send");
+    }
+
     socket_->send(message);
     completion();
   }

diff --git a/iOS/FlipperKit/FlipperWebSocket.mm b/iOS/FlipperKit/FlipperWebSocket.mm
@@ -121,6 +121,14 @@
   if (socket_ == NULL) {
     return;
   }
+
+  // Ensure the payload size is valid before sending.
+  // The maximum allowed size for a message payload is 2^53 - 1. But that is
+  // for the entire message, including any additional metadata.
+  if (message.length() > pow(2, 53) - 1) {
+    throw std::length_error("Payload is too big to send");
+  }
+
   NSString* messageObjc = [NSString stringWithUTF8String:message.c_str()];
   [socket_ send:messageObjc
       withCompletionHandler:^(NSError*) {