Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload bundled Linux and Windows builds #5540

Closed
wants to merge 3 commits into from
Closed

Upload bundled Linux and Windows builds #5540

wants to merge 3 commits into from

Conversation

passy
Copy link
Member

@passy passy commented Mar 25, 2024

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Pull Request Test Coverage Report for Build 8425706512

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.332%

Totals Coverage Status
Change from base Build 8425240016: 0.0%
Covered Lines: 8276
Relevant Lines: 14890

💛 - Coveralls

facebook-github-bot pushed a commit that referenced this pull request Mar 25, 2024
Summary:
Add --tar option to build server script for Linux and Windows
This is an attempt to restore end-user builds for Linux and Windows.

Pull Request resolved: #5539

Test Plan:
```
$ yarn build:flipper-server --linux --tar
$ cd ../dist
$ ls
flipper-server-linux  flipper-server-linux.tar.gz  flipper-server.tgz
$ tar xf flipper-server-linux.tar.gz
$ ls
flipper  flipper-runtime  lib  node_modules  package.json  README.md  server.js  static
$ file flipper-runtime
flipper-runtime: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=57a3f4c4290edb17c60db0893675551b76e30b1b, for GNU/Linux 2.6.32, stripped
```

I can't test if it actually runs right now.

 ---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/flipper/pull/5539).
* #5540
* __->__ #5539

Reviewed By: antonk52

Differential Revision: D55323840

Pulled By: passy

fbshipit-source-id: faa7655c045b27f563cfaef07632b74d0a47b5ca
@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 23a0407.

@passy
Copy link
Member Author

passy commented Mar 27, 2024

Fixes #5517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants