Moved package from AndroidManifest.xml into build.gradle namespace #5541
Conversation
|
Hi @emmanuelproulx! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you! |
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
The build failed but I don't understand how this could possibly be related to my change. Any idea? |
|
I see now that the build was broken days ago: #5519 |
This is necessary because Google requires this in AGP version 8.
|
@emmanuelproulx has updated the pull request. You must reimport the pull request before landing. |
|
I seem to have used the wrong button. |
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@emmanuelproulx has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@emmanuelproulx has updated the pull request. You must reimport the pull request before landing. |
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This is necessary because Google requires this in AGP version 8.
Summary
The code no longer works now that we're at version 8 of AGP. This is because AGP 8 requires that the package be changed to a namespace option in build.gradle.
Changelog
The React Native module now works with Android Gradle Plugin version 8.
Test Plan
I imported this in my own React Native project, and I was getting a build failed: "Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace."
Then I made this one change and rebuilt my project. The build worked and my app ran correctly.