From de245943c49a5dd1c555eb6581f1f9be8e4b4ac0 Mon Sep 17 00:00:00 2001 From: Gabriel Agamennoni Date: Tue, 3 Sep 2024 10:24:34 -0700 Subject: [PATCH] Mark overridden destructors Summary: Fix a `-Wundef` warning when building with `arvr/mode/platform010`. Reviewed By: h-friederich Differential Revision: D61980557 fbshipit-source-id: 13dcd6390e13cc6786f40368f555f2be5e89b2eb --- folly/logging/AsyncFileWriter.h | 2 +- folly/logging/StandardLogHandler.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/folly/logging/AsyncFileWriter.h b/folly/logging/AsyncFileWriter.h index 38543fbb652..2ee48a01e66 100644 --- a/folly/logging/AsyncFileWriter.h +++ b/folly/logging/AsyncFileWriter.h @@ -40,7 +40,7 @@ class AsyncFileWriter : public AsyncLogWriter { */ explicit AsyncFileWriter(folly::File&& file); - ~AsyncFileWriter(); + ~AsyncFileWriter() override; /** * Returns true if the output steam is a tty. diff --git a/folly/logging/StandardLogHandler.h b/folly/logging/StandardLogHandler.h index dd6f6209140..077b8c0c86e 100644 --- a/folly/logging/StandardLogHandler.h +++ b/folly/logging/StandardLogHandler.h @@ -46,7 +46,7 @@ class StandardLogHandler : public LogHandler { std::shared_ptr formatter, std::shared_ptr writer, LogLevel syncLevel = LogLevel::MAX_LEVEL); - ~StandardLogHandler(); + ~StandardLogHandler() override; /** * Get the LogFormatter used by this handler.