Change xcode failure to xcode warning

Reviewed By: lawrencelomax Differential Revision: D26727043 fbshipit-source-id: 38d4b1a73a511057896512807c1303091de9ca73
facebook · Mar 1, 2021 · 9e03d47 · 9e03d47
1 parent 1279ca3
commit 9e03d47
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/idb_companion/main.m b/idb_companion/main.m
@@ -564,11 +564,12 @@ int main(int argc, const char *argv[]) {
     [logger.info logFormat:@"Invoked with args=%@ env=%@", [FBCollectionInformation oneLineDescriptionFromArray:NSProcessInfo.processInfo.arguments], EnvDescription()];
     NSError *error = nil;
 
-    // Check that xcode-select returns a valid path
+    // Check that xcode-select returns a valid path, throw a big
+    // warning if not
     [FBXcodeDirectory.xcodeSelectFromCommandLine.xcodePath await:&error];
     if (error) {
       [logger.error log:error.localizedDescription];
-      return 1;
+      error = nil;
     }
 
     FBFuture<NSNumber *> *signalled = [FBFuture race:@[