Skip to content

Commit

Permalink
make comment ID optional
Browse files Browse the repository at this point in the history
Summary:
This is breaking tests now since PR comments don't have IDs https://www.internalfb.com/code/fbsource/%5B2c368e02f13cc2c6768aa843264a44169313e570%5D/fbcode/eden/addons/isl-server/src/github/githubCodeReviewProvider.ts?lines=225-205

Making the field optional.

Reviewed By: muirdm

Differential Revision: D64568889

fbshipit-source-id: 09f9c9059241d75145dbd706f6cd058d9ec5e76a
  • Loading branch information
Larry Lai authored and facebook-github-bot committed Oct 17, 2024
1 parent 9192597 commit 52b762e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion addons/isl/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export type DiffCommentReaction = {
};

export type DiffComment = {
id: string;
id?: string;
author: string;
authorName?: string;
authorAvatarUri?: string;
Expand Down

0 comments on commit 52b762e

Please sign in to comment.