From 52b762ea1de25427e1fd93fab38a322fa815ee70 Mon Sep 17 00:00:00 2001 From: Larry Lai Date: Thu, 17 Oct 2024 16:54:36 -0700 Subject: [PATCH] make comment ID optional Summary: This is breaking tests now since PR comments don't have IDs https://www.internalfb.com/code/fbsource/%5B2c368e02f13cc2c6768aa843264a44169313e570%5D/fbcode/eden/addons/isl-server/src/github/githubCodeReviewProvider.ts?lines=225-205 Making the field optional. Reviewed By: muirdm Differential Revision: D64568889 fbshipit-source-id: 09f9c9059241d75145dbd706f6cd058d9ec5e76a --- addons/isl/src/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/isl/src/types.ts b/addons/isl/src/types.ts index 60158dc8d8307..041e01308fa20 100644 --- a/addons/isl/src/types.ts +++ b/addons/isl/src/types.ts @@ -86,7 +86,7 @@ export type DiffCommentReaction = { }; export type DiffComment = { - id: string; + id?: string; author: string; authorName?: string; authorAvatarUri?: string;