Move DynamicEvent from eden to edencommon

Summary: To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces. This change move DynamicEvent from eden to edencommon. Reviewed By: kmancini Differential Revision: D54046154 fbshipit-source-id: de9466c73c0b2a2a16302cc0114e4c2a12426b30
facebook · Feb 28, 2024 · 78c7798 · 78c7798
1 parent 6a06a2c
commit 78c7798
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 120 deletions.
diff --git a/eden/fs/telemetry/CMakeLists.txt b/eden/fs/telemetry/CMakeLists.txt
@@ -16,6 +16,7 @@ target_link_libraries(
     eden_config
     eden_service_thrift_util
     eden_utils
+    edencommon::edencommon_telemetry
     fb303::fb303
     Folly::folly
 )
diff --git a/eden/fs/telemetry/DynamicEvent.cpp b/eden/fs/telemetry/DynamicEvent.cpp
diff --git a/eden/fs/telemetry/DynamicEvent.h b/eden/fs/telemetry/DynamicEvent.h
diff --git a/eden/fs/telemetry/LogEvent.h b/eden/fs/telemetry/LogEvent.h
@@ -13,7 +13,7 @@
 #include <string>
 
 #include "eden/common/os/ProcessId.h"
-#include "eden/fs/telemetry/DynamicEvent.h"
+#include "eden/common/telemetry/DynamicEvent.h"
 
 namespace facebook::eden {
 

diff --git a/eden/fs/telemetry/TARGETS b/eden/fs/telemetry/TARGETS
@@ -101,27 +101,23 @@ cpp_library(
 cpp_library(
     name = "log_info",
     srcs = [
-        "DynamicEvent.cpp",
         "SessionId.cpp",
         "SessionInfo.cpp",
     ],
     headers = [
-        "DynamicEvent.h",
         "LogEvent.h",
         "SessionId.h",
         "SessionInfo.h",
     ],
     deps = [
-        "//eden/common/utils:throw",
         "//eden/fs/utils:sysctl_util",
         "//folly:conv",
         "//folly:exception",
-        "//folly:unicode",
-        "//folly/logging:logging",
         "//folly/portability:unistd",
     ],
     exported_deps = [
         "//eden/common/os:os",
+        "//eden/common/telemetry:log_info",
         "//folly/portability:sys_types",
     ],
 )