Skip to content

Commit

Permalink
Forward fix github build break due to D54280190
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#720

When running getdeps as part of Github CI, the toolchains employed are found in "C:\Program Files" or "C:\Program Files(x86)" - both requiring quoting to execute.

Lets add quotes and fix tha.

Reviewed By: vitaut

Differential Revision: D54433098

fbshipit-source-id: d3570486a2a2b12f4649becc987f9da1ca65c796
  • Loading branch information
jdelliot authored and facebook-github-bot committed Mar 1, 2024
1 parent 0dbbe9f commit 9bde789
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/fbcode_builder/getdeps/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def _get_cmd_prefix(self):
wrapper = os.path.join(self.build_dir, "succeed.bat")
with open(wrapper, "w") as f:
f.write("@echo off\n")
f.write(f"call {vcvarsall} amd64\n")
f.write(f'call "{vcvarsall}" amd64\n')
f.write("set ERRORLEVEL=0\n")
f.write("exit /b 0\n")
return [wrapper, "&&"]
Expand Down

0 comments on commit 9bde789

Please sign in to comment.