From 9bde7896c72ccdbf0ccfa691ff142327038affd7 Mon Sep 17 00:00:00 2001 From: John Elliott Date: Fri, 1 Mar 2024 15:34:10 -0800 Subject: [PATCH] Forward fix github build break due to D54280190 Summary: X-link: https://github.com/facebookincubator/zstrong/pull/720 When running getdeps as part of Github CI, the toolchains employed are found in "C:\Program Files" or "C:\Program Files(x86)" - both requiring quoting to execute. Lets add quotes and fix tha. Reviewed By: vitaut Differential Revision: D54433098 fbshipit-source-id: d3570486a2a2b12f4649becc987f9da1ca65c796 --- build/fbcode_builder/getdeps/builder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index 4ad75b3468581..090291e871443 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -70,7 +70,7 @@ def _get_cmd_prefix(self): wrapper = os.path.join(self.build_dir, "succeed.bat") with open(wrapper, "w") as f: f.write("@echo off\n") - f.write(f"call {vcvarsall} amd64\n") + f.write(f'call "{vcvarsall}" amd64\n') f.write("set ERRORLEVEL=0\n") f.write("exit /b 0\n") return [wrapper, "&&"]