Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor the dev setup scripts to avoid duplication
Summary: I recently added a third script (setup_lfs_server.sh) on top of the existing two, and that introduced even more copy and pasta; reviewers flagged that. Duplication also makes it hard to add new common functionality (e.g. using configerator vs local files). This diff introduces two more functions that let us cut down individual scripts by ~60%. The price for that is some complexity in the functions: consuming and filtering command-line flags pretty much requires arrays; reading and saving configuration requires references. I tried to make future maintenance easier by adding good comments and unit tests. Differential Revision: D54945927 fbshipit-source-id: c58a5b7b6110bc7f789d331d609fb802f08be6f0
- Loading branch information