-
Notifications
You must be signed in to change notification settings - Fork 283
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Half of files and trees (in terms of bytes) requests are batched https://fburl.com/scuba/mononoke_test_perf/fha12kbz and those are not consistently routed. 63% of batched requests are batches of size < 5: https://fburl.com/scuba/mononoke_test_perf/b5qrq6zb most if it comes form edenfs: https://fburl.com/scuba/mononoke_test_perf/91hajq2o Because of consistent hashing, we might be better off just sending 3 paralel consistently-routed requests instead of a batch of size 3 routed to random hosts, evicting things from cache all over the place. This should help with S402137: EdenFS performance regression causing performance degradation for multiple tools This will make more trees and files to be consistently routed, which should improve caching server-side. That should relieve the load on servers and speed up requests. Given the fact we're unbatching small batches, there shouldn't be a big impact on perf client-side as those requests can be made in parallel. I did run some manual tests (not very extensive though), and the results with (multiple requests) and without this change (a batch), were similar. W Reviewed By: liubov-dmitrieva Differential Revision: D54680781 fbshipit-source-id: a35c31e8c12ccca7936190b9c228ce580f7b74ff
- Loading branch information
1 parent
ca1d8a4
commit c5d0b0e
Showing
2 changed files
with
74 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters