Skip to content

Commit

Permalink
Move Utf8 from eden to edencommon
Browse files Browse the repository at this point in the history
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.

This change moves Utf8 from eden to edencommon.

Reviewed By: fanzeyi

Differential Revision: D54341648

fbshipit-source-id: b1461a7f92963100914733d69de6eb574af3e1f9
  • Loading branch information
jdelliot authored and facebook-github-bot committed Mar 1, 2024
1 parent 48927b9 commit daad993
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 258 deletions.
3 changes: 2 additions & 1 deletion eden/fs/utils/EdenError.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
#include <folly/ExceptionWrapper.h>
#include <string_view>
#include <system_error>

#include "eden/common/utils/Utf8.h"
#include "eden/fs/service/gen-cpp2/eden_types.h"
#include "eden/fs/utils/Utf8.h"

namespace facebook::eden {
/*
Expand Down
2 changes: 1 addition & 1 deletion eden/fs/utils/PathFuncs.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include "eden/common/utils/String.h"
#include "eden/common/utils/StringConv.h"
#include "eden/common/utils/Throw.h"
#include "eden/fs/utils/Utf8.h"
#include "eden/common/utils/Utf8.h"

namespace facebook::eden {

Expand Down
17 changes: 2 additions & 15 deletions eden/fs/utils/TARGETS
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ cpp_library(
],
exported_deps = [
"fbsource//third-party/fmt:fmt",
":utf8",
"//eden/common/utils:utf8",
"//eden/fs/service:thrift-cpp2-types",
"//folly:exception_wrapper",
],
Expand Down Expand Up @@ -372,12 +372,12 @@ cpp_library(
],
exported_deps = [
"fbsource//third-party/fmt:fmt",
":utf8",
"//eden/common/utils:case_sensitivity",
"//eden/common/utils:memory",
"//eden/common/utils:string",
"//eden/common/utils:stringconv",
"//eden/common/utils:throw",
"//eden/common/utils:utf8",
"//folly:expected",
"//folly:fbstring",
"//folly:fbvector",
Expand Down Expand Up @@ -520,19 +520,6 @@ cpp_library(
],
)

cpp_library(
name = "utf8",
srcs = ["Utf8.cpp"],
headers = ["Utf8.h"],
deps = [
"//folly:unicode",
],
exported_deps = [
"//folly:range",
"//folly:utility",
],
)

cpp_library(
name = "clock",
srcs = ["Clock.cpp"],
Expand Down
26 changes: 0 additions & 26 deletions eden/fs/utils/Utf8.cpp

This file was deleted.

153 changes: 0 additions & 153 deletions eden/fs/utils/Utf8.h

This file was deleted.

10 changes: 0 additions & 10 deletions eden/fs/utils/test/TARGETS
Original file line number Diff line number Diff line change
Expand Up @@ -342,16 +342,6 @@ cpp_unittest(
],
)

cpp_unittest(
name = "utf8",
srcs = ["Utf8Test.cpp"],
supports_static_listing = False,
deps = [
"//eden/fs/utils:utf8",
"//folly/portability:gtest",
],
)

cpp_unittest(
name = "glob_test",
srcs = ["GlobMatcherTest.cpp"],
Expand Down
52 changes: 0 additions & 52 deletions eden/fs/utils/test/Utf8Test.cpp

This file was deleted.

0 comments on commit daad993

Please sign in to comment.