From df64e9d800a9809b73ce1b860ece75e9dda5b035 Mon Sep 17 00:00:00 2001 From: Yan Soares Couto Date: Tue, 24 Jan 2023 12:53:21 -0800 Subject: [PATCH] mirror: Log less and make concurrency customisable Summary: Slices were very noisy, so I made them log less. Plus now you can specify the concurrency of the command via CLI args. I tweaked it and saw no improvements though :( Reviewed By: markbt Differential Revision: D42683915 fbshipit-source-id: 5930a44c6a24fd48560512dd83a630c283c9a351 --- .../slice_repository/src/lib.rs | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/eden/mononoke/commit_traversal/slice_repository/src/lib.rs b/eden/mononoke/commit_traversal/slice_repository/src/lib.rs index 498eeb1044687..47b945dfc5995 100644 --- a/eden/mononoke/commit_traversal/slice_repository/src/lib.rs +++ b/eden/mononoke/commit_traversal/slice_repository/src/lib.rs @@ -158,14 +158,19 @@ where .await?; let mut slices = Vec::new(); + let mut next_log_size = 1; while let Some((cur_gen, mut heads)) = head_generation_groups.pop_last() { - info!( - ctx.logger(), - "Adding slice starting at generation {} with {} heads ({} slices queued)", - cur_gen, - heads.len(), - head_generation_groups.len() - ); + if slices.len() > next_log_size { + info!( + ctx.logger(), + "Adding slice starting at generation {} with {} heads ({} slices queued, {} so far)", + cur_gen, + heads.len(), + head_generation_groups.len(), + slices.len(), + ); + next_log_size *= 2; + } let mut new_heads_groups = HashMap::new(); let mut seen: HashSet<_> = heads.iter().cloned().collect(); while let Some(csid) = heads.pop() {