Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show the existence of bug #751

Merged
merged 2 commits into from
Oct 16, 2024
Merged

chore: show the existence of bug #751

merged 2 commits into from
Oct 16, 2024

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Oct 15, 2024

This PR just updates a single test to show that existence of a bug.

notice that color:blue has the same className for ::before:hover and :hover::before.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/scripts@0.8.0 size:compare
./size-compare.js /tmp/tmp.EuR431zbMs /tmp/tmp.O7cStLGDh0

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 899 899 1.00
· minified 3,223 3,223 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 563,025 563,025 1.00
· minified 10,185,368 10,185,368 1.00
rollup-example/.build/stylex.css
· compressed 99,154 99,154 1.00
· minified 745,649 745,649 1.00

@nmn nmn merged commit ffca010 into main Oct 16, 2024
8 checks passed
@nmn nmn deleted the chore/repro-bug branch October 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants