-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS S3 Image and Document uploads #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and senderID as media name
sachinkarve
commented
Jul 1, 2024
src/main/java/com/meta/cp4m/configuration/RootConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/meta/cp4m/configuration/RootConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/meta/cp4m/configuration/RootConfiguration.java
Outdated
Show resolved
Hide resolved
|
||
import static org.junit.jupiter.api.Assertions.*; | ||
|
||
class S3PreProcessorTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that this will be a hard test to write for s3, for the sake of this detail in the description for this PR how you manually tested this and then in a later PR we also need a test for preprocessors in general
…ge or document is uploaded
hunterjackson
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capability to upload Image and Documents sent from WA client to AWS S3.
ConfigFile should look something like