Skip to content

Commit

Permalink
Clean up old test schema and test data
Browse files Browse the repository at this point in the history
Summary:
For historical reasons we had two versions of the
`glean.test.Predicate` predicate which was very confusing. This diff
removes the old version, collapses the schemas and updates all the
tests as necessary.

Reviewed By: josefs

Differential Revision: D59809144

fbshipit-source-id: 3c7bc9a1f26ce7c4e57c11f0bf6615ec41588950
  • Loading branch information
Simon Marlow authored and facebook-github-bot committed Jul 22, 2024
1 parent 51a9031 commit ca604cb
Show file tree
Hide file tree
Showing 23 changed files with 222 additions and 387 deletions.
6 changes: 0 additions & 6 deletions glean.cabal.in
Original file line number Diff line number Diff line change
Expand Up @@ -1713,12 +1713,6 @@ common angle-test
glean:if-glean-hs,
glean:schema

test-suite angle-test-onemany
import: test, angle-test
type: exitcode-stdio-1.0
main-is: Angle/OneManyTest.hs
ghc-options: -main-is Angle.OneManyTest

test-suite angle-test-angle
import: test, angle-test
type: exitcode-stdio-1.0
Expand Down
2 changes: 1 addition & 1 deletion glean/haxl/tests/IntegrationTest.hs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ getTest env repo = TestLabel "GetRec" $

rs <- runHaxl e $ mapM Glean.getKey stubs
assertBool "Glean.getKey" $
sort (map (fromNat . Glean.Test.kitchenSink_nat) rs) == [ 0, 0, 0, 42 ] &&
sort (map (fromNat . Glean.Test.kitchenSink_nat) rs) == [ 0, 0, 42, 43 ] &&
all (isNothing . Sys.blob_key . Glean.Test.kitchenSink_pred) rs

rs <- runHaxl e $ mapM Glean.getKeyRec stubs
Expand Down
Loading

0 comments on commit ca604cb

Please sign in to comment.