-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the callback of send operation. #458
Open
NathanLi
wants to merge
10
commits into
facebookincubator:main
Choose a base branch
from
NathanLi:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f1e1cee
Add the callback of send operation.
NathanLi c7b8f8d
Merge remote-tracking branch 'facebook/master'
NathanLi 296c151
Rename SRSendCompleteBlock to SRSendCompletionBlock
NathanLi f599d0c
Fixed naming problems
NathanLi ac1c632
Change the call back key for uniqune.
NathanLi 399e25b
Remove useless white space.
NathanLi 00545e5
Remove useless white space.
NathanLi b313fe8
Improving the method chains and signatures for error:completion: styl…
NathanLi 706623c
Use `[NSValue valueWithRange:dataRange]` as a key of _sendCallbacks.
NathanLi f630b95
Change the error message.
NathanLi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are constructing this one time only, let's ensure we can't mutate
completion
later.You would need to replace the code block with this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above code block also contains the fixes for minor nits, like whitespace, naming as well as proper method attributes (
NS_UNAVAILABLE
to make sure no one can initialize this class withalloc] init]
ornew
as well as attribute for designated initializer).