Skip to content

Commit

Permalink
[antlir2][vm] disable more dev modes
Browse files Browse the repository at this point in the history
Summary:
Cat and mouse. Let's not lose.

Context: https://fb.workplace.com/groups/td.users/posts/3452228681739793?comment_id=3458110481151613

Test Plan:
CI

```
$ arc citrace labels -p fbcode fbcode//schedulers/tangram/agent/tests/sudo:secondary_container_vm_tests
╔═══ fbcode//schedulers/tangram/agent/tests/sudo:secondary_container_vm_tests ══
║ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ CI Labels ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
║ ┃ ▫ fbcode//schedulers/tangram/agent/tests/sudo:secondary_container_vm_tests
║ ┃ ├── Package labels:
║ ┃ │   ├── ci:diff:linux:dev
║ ┃ │   ├── ci:continuous:linux:dev
║ ┃ │   ├── ci:continuous:linux:opt
║ ┃ │   ├── ci:diff:linux:collect_coverage
║ ┃ │   ├── ci:continuous:linux:collect_coverage
║ ┃ │   ├── ci:continuous:linux:fbcode//mode/dev-tsan
║ ┃ │   └── ci:continuous:linux:fbcode//mode/opt-tsan
║ ┃ └── Target labels:
║ ┃     ├── uses_sudo
║ ┃     ├── heavyweight
║ ┃     ├── ci:overwrite
║ ┃     ├── ci:diff:linux:opt
║ ┃     ├── ci:continuous:linux:opt
║ ┃     ├── ci:continuous:linux:opt
║ ┃     ├── ci:diff:linux:collect_coverage
║ ┃     ├── ci:continuous:linux:collect_coverage
║ ┃     ├── ci:continuous:linux:fbcode//mode/opt-tsan
║ ┃     └── ci:continuous:linux:fbcode//mode/opt-tsan
```

Differential Revision: D64915273

fbshipit-source-id: 522cde1c569182bd014835614d6ac9ec52d307ce
  • Loading branch information
wujj123456 authored and facebook-github-bot committed Oct 24, 2024
1 parent 747cdb6 commit ce4ad8d
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions antlir/antlir2/antlir2_vm/bzl/disable_dev_mode.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,24 @@ def disable_dev_mode(labels: list[str]) -> list[str]:
"""
labels += ci.labels(
ci.replace({
# Override tags with default dev mode. This is lossy, because we
# will drop all other modes but opt for simplicity. The goal of VM
# tests isn't to test all build modes. We just need that one mode
# works and is fast enough for the VM.
ci.linux(ci.x86_64()): ci.linux(ci.x86_64(ci.opt())),
ci.linux(ci.aarch64()): ci.linux(ci.aarch64(ci.opt())),
# ci.mode() seems to be rather diverse. Try covering everything
# starting with dev. If there is a matching opt mode, use that. Or
# we use the vanilla opt.
ci.linux(ci.mode("fbcode//mode/dev-asan")): ci.linux(ci.mode("fbcode//mode/opt-asan")),
ci.linux(ci.mode("fbcode//mode/dev-tsan")): ci.linux(ci.mode("fbcode//mode/opt-tsan")),
ci.linux(ci.mode("fbcode//mode/dev-ubsan")): ci.linux(ci.mode("fbcode//mode/opt-ubsan")),
# Not sure if the link group issue we had is specific to dev
# (D51891046). Give opt-lg a chance.
ci.linux(ci.mode("fbcode//mode/dev-lg")): ci.linux(ci.mode("fbcode//mode/opt-lg")),
ci.linux(ci.mode("fbcode//mode/dev-cov")): ci.linux(ci.opt()),
ci.linux(ci.mode("fbcode//mode/dev-nosan")): ci.linux(ci.opt()),
ci.linux(ci.mode("fbcode//mode/dev-nosan-lg")): ci.linux(ci.opt()),
}),
fbcode_ci.use_opt_instead_of_dev(),
)
Expand Down

0 comments on commit ce4ad8d

Please sign in to comment.