[starlark] Rename Error::new -> new_kind

Summary: To free the `new` name for "default" constructor. That should be `ErrorKind::Other` or `ErrorKind::Native`?

Test Plan: CI

Reviewed By: JakobDegen

Differential Revision: D63304734

fbshipit-source-id: 55c49781a8b05f18824ff8952bb5ebe8e851497b

antlir/bzl/shape2/bzl2ir.rs

@@ -130,9 +130,9 @@ impl<'v> StarlarkValue<'v> for TypeId {
                 args.no_named_args()?;
                 args.positional1(eval.heap())
             }
-            _ => Err(starlark::Error::new(starlark::ErrorKind::Other(anyhow!(
+            _ => Err(starlark::Error::new_other(anyhow!(
                 "only structs and enums are callable, not ({ty:#?})"
-            )))),
+            ))),
         }
     }
 }