Skip to content

Commit

Permalink
Remove extraneous semicolon from hbt/src/tagstack/Stream.h
Browse files Browse the repository at this point in the history
Summary:
Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631145
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 29, 2023
1 parent 7fc0151 commit 52eb3cb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hbt/src/tagstack/Stream.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ class RingBufferStream : protected ringbuffer::Consumer<TExtraData> {
HBT_THROW_SYSTEM_CODE_IF(0 > ret, toErrorCode(-ret))
<< "RingBuffer read failed due to unexpected causes: "
<< toErrorCode(-ret).message();
;
HBT_THROW_ASSERT_IF(event == nullptr);
HBT_THROW_ASSERT_IF(
next_event_ != nullptr && event->happenedBefore(*next_event_));
Expand Down

0 comments on commit 52eb3cb

Please sign in to comment.