From 52eb3cbb04cb9b613f69f3fa7760f06a3f57b583 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Wed, 29 Nov 2023 15:08:34 -0800 Subject: [PATCH] Remove extraneous semicolon from hbt/src/tagstack/Stream.h Summary: Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them. This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function). This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers. This should be a low-risk diff: if it compiles, it works. Reviewed By: meyering Differential Revision: D51631145 --- hbt/src/tagstack/Stream.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hbt/src/tagstack/Stream.h b/hbt/src/tagstack/Stream.h index 4ff17ef4..b34871fc 100644 --- a/hbt/src/tagstack/Stream.h +++ b/hbt/src/tagstack/Stream.h @@ -87,7 +87,6 @@ class RingBufferStream : protected ringbuffer::Consumer { HBT_THROW_SYSTEM_CODE_IF(0 > ret, toErrorCode(-ret)) << "RingBuffer read failed due to unexpected causes: " << toErrorCode(-ret).message(); - ; HBT_THROW_ASSERT_IF(event == nullptr); HBT_THROW_ASSERT_IF( next_event_ != nullptr && event->happenedBefore(*next_event_));