Skip to content

Commit

Permalink
Remove extraneous semicolon from hbt/src/perf_event/PmuDevices.cpp (#189
Browse files Browse the repository at this point in the history
)

Summary:
Pull Request resolved: #189

Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631141

fbshipit-source-id: 522b1779e6859835ec21ec07fcef844a56664601
  • Loading branch information
r-barnes authored and facebook-github-bot committed Dec 12, 2023
1 parent a624dab commit 5a101a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hbt/src/perf_event/PmuDevices.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ std::string PmuTypeToStr(PmuType pmu_type) {
CASE_PMU_TYPE(uncore_mchbm);

CASE_PMU_TYPE(armv8_pmuv3);
};
}
}

/// Macro to generate "if" statements for PMU string names.
Expand Down

0 comments on commit 5a101a1

Please sign in to comment.