From 5a101a147b7c8aa5d25456c045de81e7d00d576e Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Tue, 12 Dec 2023 10:43:20 -0800 Subject: [PATCH] Remove extraneous semicolon from hbt/src/perf_event/PmuDevices.cpp (#189) Summary: Pull Request resolved: https://github.com/facebookincubator/dynolog/pull/189 Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them. This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function). This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers. This should be a low-risk diff: if it compiles, it works. Reviewed By: meyering Differential Revision: D51631141 fbshipit-source-id: 522b1779e6859835ec21ec07fcef844a56664601 --- hbt/src/perf_event/PmuDevices.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbt/src/perf_event/PmuDevices.cpp b/hbt/src/perf_event/PmuDevices.cpp index 8643969e..05c092e6 100644 --- a/hbt/src/perf_event/PmuDevices.cpp +++ b/hbt/src/perf_event/PmuDevices.cpp @@ -88,7 +88,7 @@ std::string PmuTypeToStr(PmuType pmu_type) { CASE_PMU_TYPE(uncore_mchbm); CASE_PMU_TYPE(armv8_pmuv3); - }; + } } /// Macro to generate "if" statements for PMU string names.