Remove extraneous semicolon from hbt/src/ringbuffer/PerCpuRingBuffer.h #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them. This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function). This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers. This should be a low-risk diff: if it compiles, it works. Reviewed By: meyering Differential Revision: D51631126
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51631126 |
|
This pull request has been merged in 85ecd75. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Extraneous semicolons are a code smell and can mask more serious problems.
-Wextra-semi-stmtfinds them.This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).
This file is drawn from a heavy-hitting list, so fixing this problem will allow many other files to take advantage of the safety
-Wextra-semi-stmtoffers.This should be a low-risk diff: if it compiles, it works.
Reviewed By: meyering
Differential Revision: D51631126