Fix missing nits from the Tablet refactor

Summary: Fix some missed nits. Reviewed By: sdruzkin, darrenfu, helfman Differential Revision: D56534111
facebookincubator · Apr 24, 2024 · d4ba30f · d4ba30f
1 parent ddb6f1c
commit d4ba30f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/dwio/nimble/tablet/TabletWriter.cpp b/dwio/nimble/tablet/TabletWriter.cpp
@@ -20,7 +20,6 @@
 #include "dwio/nimble/tablet/Compression.h"
 #include "dwio/nimble/tablet/Constants.h"
 #include "dwio/nimble/tablet/FooterGenerated.h"
-#include "dwio/nimble/velox/MetadataGenerated.h"
 
 namespace facebook::nimble {
 namespace {

diff --git a/dwio/nimble/tablet/TabletWriter.h b/dwio/nimble/tablet/TabletWriter.h
@@ -16,7 +16,9 @@
 
 #pragma once
 
-#include "dwio/nimble/tablet/TabletReader.h"
+#include "dwio/nimble/common/Checksum.h"
+#include "velox/common/file/File.h"
+#include "velox/common/memory/Memory.h"
 
 namespace facebook::nimble {
 struct Stream {

diff --git a/dwio/nimble/velox/VeloxWriter.cpp b/dwio/nimble/velox/VeloxWriter.cpp
@@ -61,7 +61,9 @@ class WriterContext : public FieldWriterContext {
   uint64_t stripeSize{0};
   std::vector<uint64_t> rowsPerStripe;
 
-  WriterContext(MemoryPool& memoryPool, VeloxWriterOptions options)
+  WriterContext(
+      velox::memory::MemoryPool& memoryPool,
+      VeloxWriterOptions options)
       : FieldWriterContext{memoryPool, options.reclaimerFactory()},
         options{std::move(options)},
         logger{this->options.metricsLogger} {
@@ -411,7 +413,7 @@ void initializeEncodingLayouts(
 } // namespace
 
 VeloxWriter::VeloxWriter(
-    MemoryPool& memoryPool,
+    velox::memory::MemoryPool& memoryPool,
     const velox::TypePtr& schema,
     std::unique_ptr<velox::WriteFile> file,
     VeloxWriterOptions options)