misc: Surface clear parsing error for invalid prestopage header #14047
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Copyright (c) Facebook, Inc. and its affiliates. | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| name: Run Checks | |
| on: | |
| pull_request: | |
| types: | |
| - opened | |
| - reopened | |
| - edited | |
| - synchronize | |
| permissions: | |
| contents: read | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.repository }}-${{ github.head_ref || github.sha }} | |
| cancel-in-progress: true | |
| jobs: | |
| check-matrix: | |
| name: ${{ matrix.config.name }} | |
| runs-on: ubuntu-latest | |
| container: ghcr.io/facebookincubator/velox-dev:check | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| config: | |
| - { name: "License Header", | |
| command: "header-fix", | |
| message: "Found missing License Header(s)", | |
| } | |
| - { name: "Code Format", | |
| command: "format-fix", | |
| message: "Found format issues" | |
| } | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 0 | |
| - name: Fix git permissions | |
| # Usually actions/checkout does this but as we run in a container | |
| # it doesn't work | |
| run: git config --global --add safe.directory ${GITHUB_WORKSPACE} | |
| - name: Check ${{ matrix.config.name }} | |
| run: | | |
| make ${{ matrix.config.command }} | |
| if ! git diff --quiet; then | |
| diff=`git --no-pager diff` | |
| echo "${{ matrix.command.message }} in the following files:" | |
| git --no-pager diff --name-only | |
| echo "Check the Job summary for a copy-pasteable patch." | |
| echo "> [!IMPORTANT]" >> $GITHUB_STEP_SUMMARY | |
| echo "${{ matrix.config.message }}" >> $GITHUB_STEP_SUMMARY | |
| echo "> Please apply fix using:" >> $GITHUB_STEP_SUMMARY | |
| echo "\`\`\`sh" >> $GITHUB_STEP_SUMMARY | |
| echo "patch -p1 <<EOF" >> $GITHUB_STEP_SUMMARY | |
| echo "$diff" >> $GITHUB_STEP_SUMMARY | |
| echo "EOF" >> $GITHUB_STEP_SUMMARY | |
| echo "\`\`\`" >> $GITHUB_STEP_SUMMARY | |
| exit 1 | |
| fi | |
| title-check: | |
| name: PR Title Format | |
| runs-on: ubuntu-latest | |
| steps: | |
| - shell: python | |
| env: | |
| title: "${{ github.event.pull_request.title }}" | |
| run: | | |
| import re | |
| import os | |
| title = os.environ["title"] | |
| title_re = r"^(feat|fix|build|test|docs|refactor|misc)(\(.+\))?!?: ([A-Z].+)[^.]$" | |
| match = re.search(title_re, title) | |
| if match is None: | |
| print("::error::Please follow conventional commit guidelines in commit titles as described in CONTRIBUTING.md: https://github.com/facebookincubator/velox/blob/main/CONTRIBUTING.md#commit-messages") | |
| exit(1) | |
| else: | |
| exit(0) |