Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include and exclude in sdist #236

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix include and exclude in sdist #236

merged 2 commits into from
Mar 15, 2024

Conversation

mmuckley
Copy link
Contributor

@mmuckley mmuckley commented Mar 11, 2024 •
edited
Loading

Do proper exclusion for tests/ and projects/.

See the following for documentation:

https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html

@mmuckley mmuckley requested a review from mhavasi March 11, 2024 13:57
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2024
mhavasi
mhavasi approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mhavasi mhavasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important changes, thanks for the PR.

@mmuckley mmuckley merged commit 3437920 into main Mar 15, 2024
3 checks passed
@mmuckley mmuckley deleted the mmuckley/package_data_fix branch March 15, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhavasi mhavasi mhavasi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmuckley @mhavasi @facebook-github-bot