Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the necessity of creating a dictionary in data_utils.py #391

Open
Arith2 opened this issue Oct 16, 2024 · 0 comments
Open

Comments

@Arith2
Copy link

Arith2 commented Oct 16, 2024

Hi, recently I am running DLRM training. I do not understnad the necessity of creating a dictionary in data_utils.py after a modulus operation. This is time-expensive. I know the dictionary is used to collect unique values and then assign correpsonding index to it. But why it is necessary to keep this process here? A simple hashing function, like Sigrid hash, or just modulus should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant