Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#879 Inverted option for STEPS style #880

Merged

Conversation

zdavkeos
Copy link
Contributor

@zdavkeos zdavkeos commented Nov 2, 2023

New line style like STEPS but drawn the opposite way.
Screenshot 2023-11-01 at 7 16 40 PM

New line style like STEPS but drawn the opposite way
@zdavkeos
Copy link
Contributor Author

@facontidavide & @mikkelti I am not crazy about the name "Inverted Steps", that's qwt's terminology. I would be very open to any suggestions.

@mikkelti
Copy link

@zdavkeos Inspired by matplotlib's terminology, you could call them Steps (pre) and Steps (post) or something like that.

@zdavkeos
Copy link
Contributor Author

zdavkeos commented Dec 3, 2023

@mikkelti I like the pre/post nomenclature much better. Change has been pushed to pr.

pj_steps_pre_post

Co-authored-by: Davide Faconti <davide.faconti@gmail.com>
@zdavkeos
Copy link
Contributor Author

Good catch @facontidavide , Thanks!

@facontidavide facontidavide merged commit 7450c6a into facontidavide:main Jan 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants