Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS-O] drop broken test hook from Fast-CDR import #986

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Jun 26, 2024

The tests were not imported but still referenced in the cmake depending on the system cmake version.

My build (Debian testing, ROS-O) just got stuck on:

CMake Error at plotjuggler_plugins/ParserROS/rosx_introspection/3rdparty/Fast-CDR/CMakeLists.txt:136 (add_subdirectory):
  add_subdirectory given source "test" which is not an existing directory.

It looks like you imported the library without its tests, but did not remove the cmake reference.

The tests were not imported but still referenced in the cmake depending on the system cmake version.
@v4hn
Copy link
Contributor Author

v4hn commented Jun 26, 2024

I just noticed the same mistake exists in https://github.com/facontidavide/rosx_introspection , not sure about others.

@facontidavide facontidavide merged commit f4f9d41 into facontidavide:main Aug 10, 2024
13 of 14 checks passed
@facontidavide
Copy link
Owner

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants