Merge pull request #825 from factly/fix/api/cache

fix cache issue
factly · Dec 13, 2022 · b7f7e10 · b7f7e10
2 parents a856936 + ab04bfc
commit b7f7e10
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/api/util/cache/middleware.go b/api/util/cache/middleware.go
@@ -8,7 +8,6 @@ import (
 	"fmt"
 	"io"
 	"io/ioutil"
-	"log"
 	"net/http"
 	"strings"
 
@@ -24,8 +23,9 @@ type requestBody struct {
 func CachingMiddleware() func(http.Handler) http.Handler {
 	return func(next http.Handler) http.Handler {
 		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-			log.Println(" CachingMiddleware entry")
+
 			body := requestBody{}
+			spaceId := r.Header.Get("x-space")
 			bodyBytes, _ := ioutil.ReadAll(r.Body)
 			err := json.Unmarshal(bodyBytes, &body)
 			if err != nil {
@@ -50,7 +50,7 @@ func CachingMiddleware() func(http.Handler) http.Handler {
 
 			// hash query
 			h := md5.New()
-			_, _ = io.WriteString(h, fmt.Sprint(queryStr, varString))
+			io.WriteString(h, fmt.Sprint(queryStr, varString, spaceId))
 			hash := hex.EncodeToString(h.Sum(nil))
 
 			respBodyBytes, err := GlobalCache.Get(r.Context(), hash)
@@ -64,7 +64,6 @@ func CachingMiddleware() func(http.Handler) http.Handler {
 			r.Body.Close()
 			r.Body = ioutil.NopCloser(bytes.NewBuffer(bodyBytes))
 
-			log.Println(" CachingMiddleware exit")
 			next.ServeHTTP(w, r)
 		})
 	}

diff --git a/api/util/cache/response.go b/api/util/cache/response.go
@@ -27,7 +27,6 @@ func (myrw *CacheResponseWriter) WriteHeader(header int) {
 
 func RespMiddleware(next http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		log.Println(" RespMiddleware entry")
 		// Create a response writer:
 		crw := &CacheResponseWriter{
 			ResponseWriter: w,
@@ -36,6 +35,7 @@ func RespMiddleware(next http.Handler) http.Handler {
 
 		body := requestBody{}
 		bodyBytes, _ := ioutil.ReadAll(r.Body)
+		spaceId := r.Header.Get("x-space")
 		err := json.Unmarshal(bodyBytes, &body)
 		if err != nil {
 			w.WriteHeader(http.StatusInternalServerError)
@@ -58,7 +58,7 @@ func RespMiddleware(next http.Handler) http.Handler {
 
 		_ = json.Unmarshal(saveBytes, &data)
 
-		err = SaveToCache(r.Context(), fmt.Sprint(queryStr, varString), data)
+		err = SaveToCache(r.Context(), fmt.Sprint(queryStr, varString, spaceId), data)
 		if err != nil {
 			log.Println(err.Error())
 		}
@@ -67,6 +67,5 @@ func RespMiddleware(next http.Handler) http.Handler {
 			log.Printf("Failed to send out response: %v", err)
 		}
 
-		log.Println(" RespMiddleware exit")
 	})
 }