Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizers can set pickup location, pickup time, and ready to start using a map preview on mission edit view #563

Open
utunga opened this issue May 18, 2020 · 0 comments
Labels
organizer Belongs to the organizer view

Comments

@utunga
Copy link
Contributor

utunga commented May 18, 2020

Part of the mission edit user story - #431

This card is to ensure that, on the mission edit view, organizers are able to:

  • set pickup time
  • set pickup location (with a preview of location)
  • check the 'ready to start' box
  • **update 'pickup notes' for the volunteer **

Many of these things were addressed per #552. What may be new is that we need to be able to confirm and preview the address using the AddressAutocomplete component. Also we want the pickup notes to be editable as a text area.

The fields involved are:

"pickUpWindow": {
  "timeWindowType": "exact",
  "startTime": "2020-05-17T18:58:28.828764"
},

For now we only need timeWindowType==exact for pickup. So just pick date/time and set timeWindowType to exact.

"pickUpLocation": {
  "address": "1012 N Mariposa Ave #911, Los Angeles, CA 90029, USA",
  "lat": 34.0895079,
  "lng": -118.2988146,
  "label": ""
},

We need to use AddressAutocomplete function here. Hopefully we can fit it in. Design review may be needed? Based on UX feedback, we really need the preview here to ensure that the address doesn't end up wrong and people end up going to the wrong place.

[ As I write this, AddressAutocomplete doesn't let you set the 'label' for an address but this is something we should address (as an optional component). This would be something like 'McGrath Family Farm'. In the case of pickup location, it's particularly important to have an address label.

The reason for the separate field is because in our old geocoder, putting a label (like 'McGrath Family Farm' at the start of the main address can confuse the geocoder). However we upgraded to google maps geocoder - so if the address can be recognized even with the label in place at the beginning then perhaps its OK to leave out the label as an editable field. If. however, it does confuse google maps geocoder tto have that int here then it would be nice to have to add (optional) editability of that label as part of the AdressAutoComplete component. ]

"pickUpNotes": "",

This should be an editable text area

"readyToStart": false,

This should be an editable checkbox. Because the usual flow is to set pick up time/location etc and then (sometimes but not always) check 'ready to start' at that time it would be helpful to have this checkbox right in the edit view. (It is also available in the 'actions' menu at the mission control level)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
organizer Belongs to the organizer view
Projects
None yet
Development

No branches or pull requests

1 participant