Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizer edit mission details - WIP (needs finishing or replacing) #454

Closed
wants to merge 7 commits into from

Conversation

Eihcir0
Copy link
Collaborator

@Eihcir0 Eihcir0 commented May 4, 2020

@mat10tng asked me to submit this wip pr because I will be busy the next couple days and he said he might have time to look at it.

Here are the biggest issues remaining on this:

  1. AlgoliaPlaces does not have a clean way to set an initial value -- they're recommended way is by directly manipulating the input node's value (like document.querySelector("#outer-div-id input").value = myAddress). It would probably be cleanest to just create a wrapper around this that can take in initialValue and deal with it itself
  2. The logic for the datetime selectors currently found in MissionCreate is pretty involved and highly coupled with the rendering component. Probably best bet for that is to create a nice clean fully encapsulated wrapper component that just takes value, onChange, and initialValue and handles the rest. Pull out all of that logic from MissionCreate
  3. I haven't even started looking at the selector for the volunteers / phone number
  4. Cleanup, this is still very much in a wip state. The MissionEditView was copied from the DetailsView and I've just been focused on getting it working so sorry for the current state

@utunga utunga changed the title Organizer edit mission details (WIP - NOT READY FOR REVIEW) Organizer edit mission details - WIP (needs finishing or replacing) May 13, 2020
@jwu910 jwu910 marked this pull request as draft May 19, 2020 22:31
@mat10tng
Copy link
Collaborator

the work keep going in #619

@mat10tng mat10tng closed this May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants