Adding volunteer, ready-to-startinfo to organizer edit mission screen #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n organizer edit mission screen.
mat10tng
reviewed
May 21, 2020
| mission.status === MissionStatus.unassigned || | ||
| mission.status === MissionStatus.tentative || | ||
| mission.status === MissionStatus.assigned; | ||
|
|
There was a problem hiding this comment.
outside of the class
const volunteerStatus = [MissionStatus.unassigned, MissionStatus.tentative, MissionStatus.assigned]
inside of the class
const volunteerEditable = volunteerStatus.includes(mission.status)
mat10tng
reviewed
May 21, 2020
| selectedVolunteer && values.status === MissionStatus.tentative | ||
| ? selectedVolunteer.volunteerPhoneNumber | ||
| : "", | ||
| readyToStart: values.readyToStart, |
There was a problem hiding this comment.
const getVolunteerAttribute = (selectedVolunteer, status, attr) => {
if(selectedVolunteer && status === MissionStatus.tentative){
return selectedVolunteer[attr]
}
return ""
}
{...,
tentativeVolunteerUid = getVolunteerAttribute(selectedVolunteer, values.status, "volunteerUid")
}
There was a problem hiding this comment.
Had to add one more param to the "getVolunteerAttribute" function but should capture what you are pointing out.
There was a problem hiding this comment.
It did not look as pretty as I had hope, my bad there, lets keep it for now
mat10tng
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this GitHub issue
#561