Remove all those warnings #615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g an executive decision on this one instead of opening a long slack thread - 'suggested' much more generic than 'prefered'.
decisions but if it looks like people may want to reuse this code soon used comments instead of outright delete
qdozaq
reviewed
May 23, 2020
| </Row> | ||
| ); | ||
| }; | ||
| // const MissionStatusRow = ({ classes, mission }) => { |
There was a problem hiding this comment.
is this used anymore? Should it just be removed?
| @@ -13,7 +13,6 @@ import DashboardIcon from "@material-ui/icons/Dashboard"; | |||
| import DoubleArrowIcon from "@material-ui/icons/DoubleArrow"; | |||
| import ExitToApp from "@material-ui/icons/ExitToApp"; | |||
| import MenuIcon from "@material-ui/icons/Menu"; | |||
| import MoveToInboxIcon from "@material-ui/icons/MoveToInbox"; | |||
There was a problem hiding this comment.
Latest master uses this icon so need to add back
| @@ -21,7 +21,7 @@ import { User, useOrganization } from "../../model"; | |||
| import Mission from "../../model/Mission"; | |||
| import { routes } from "../../routing"; | |||
| import { useFirestoreConnect } from "react-redux-firebase"; | |||
| import FoodBoxDeliveryIcon from "../../component/icons/FoodBoxDeliveryIcon"; | |||
| //import FoodBoxDeliveryIcon from "../../component/icons/FoodBoxDeliveryIcon"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes in a few places - mostly removing things that were generating warnings.
They're all minor but if we don't remove them then the warnings become useless..
Before:
After:
--
Also I had to change <A> to <Button> to avoid an accessibility warning. And fixed the spelling/changed 'prefered' to 'suggested' while I was at it.
Before
*After
Not happy with the spacing of the 'no thanks!' but in the end it was taking too long to fix and its not worse than what was there before!